| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Subject: | Re: logical replication busy-waiting on a lock |
| Date: | 2017-06-08 23:06:50 |
| Message-ID: | 20170608230650.d2rilnhyw6eim6mm@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2017-06-03 04:50:00 +0200, Petr Jelinek wrote:
> One thing I don't like is the GetLastLocalTransactionId() that I had to
> add because we clear the proc->lxid before we get to AtEOXact_Snapshot()
> but I don't have better solution there.
I dislike that quite a bit - how about we instead just change the
information we keep in exportedSnapshots? I.e. store a pointer to an
struct ExportedSnapshot
{
char *exportedAs;
Snapshot snapshot;
}
Then we can get rid of that relatively ugly list_length() business too.
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-06-08 23:28:01 | Re: PG10 transition tables, wCTEs and multiple operations on the same table |
| Previous Message | Andres Freund | 2017-06-08 22:48:24 | Re: Get stuck when dropping a subscription during synchronizing table |