From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Dang Minh Huong <kakalot49(at)gmail(dot)com> |
Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Kha Nguyen <nlhkha(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Extra Vietnamese unaccent rules |
Date: | 2017-06-06 15:31:21 |
Message-ID: | 20170606153121.GK14212@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jun 7, 2017 at 12:10:25AM +0900, Dang Minh Huong wrote:
> > On Jun 4, 29 Heisei, at 00:48, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> >>>> Shouldn't you use "or is_letter_with_marks()", instead of "or len(...)
> >>>>> 1"? Your test might catch something that isn't based on a 'letter'
> >>>> (according to is_plain_letter). Otherwise this looks pretty good to
> >>>> me. Please add it to the next commitfest.
> >>>
> >>> Thanks for confirm, sir.
> >>> I will add it to the next CF soon.
> >>
> >> Sorry for lately response. I attach the update patch.
> >
> > Uh, there is no patch attached.
> >
>
> Sorry sir, reattach the patch.
> I also added it to the next CF and set reviewers to Thomas Munro. Could you confirm for me.
There seems to be a problem. I can't see a patch dated 2017-06-07 on
the commitfest page:
https://commitfest.postgresql.org/14/1161/
I added the thread but there was no change. (I think the thread was
already present.) It appears it is not seeing this patch as the latest
patch.
Does anyone know why this is happening?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-06-06 15:35:49 | Re: [JDBC] Channel binding support for SCRAM-SHA-256 |
Previous Message | Robert Haas | 2017-06-06 15:30:57 | Re: Update comments in nodeModifyTable.c |