| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: shm_toc_lookup API |
| Date: | 2017-06-05 19:10:05 |
| Message-ID: | 20170605191005.hi2j2wfw2g3aucdq@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-06-05 15:06:06 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2017-06-05 14:57:10 -0400, Tom Lane wrote:
> >> Meh. Without volatile, I think that the compiler would be within its
> >> rights to elide the nentry local variable and re-fetch toc->toc_nentry
> >> each time through the loop.
>
> > I don't think that's true.
>
> Perhaps not, but I'm not quite convinced. Anyway it doesn't matter,
> at least not here.
If not, we have a bunch of bugs in other files. So if there are
concerns, we should better resolve them.
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Van Fleet | 2017-06-05 19:30:47 | HACKERS[PROPOSAL] split ProcArrayLock into multiple parts |
| Previous Message | Andrew Dunstan | 2017-06-05 19:06:33 | Re: PROVE_FLAGS |