| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fixed malformed error message on malformed SCRAM message. |
| Date: | 2017-06-02 06:32:16 |
| Message-ID: | 20170602063216.GE1500331@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Fri, Jun 02, 2017 at 02:20:00AM -0400, Tom Lane wrote:
> BTW, since you mention COMMERROR uses in auth.c, isn't the usage at
> line 687 wrong? It sure looks like the author supposed that that
> ereport call wouldn't return, but it will. Adjacent similar calls
> clean up and return NULL.
Probably, though one could argue for proceeding with the short password.
Deserves a comment if log-only is intentional.
The lack of an exit after COMMERROR "client selected an invalid SASL
authentication mechanism" looks like a bug.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ray Warren | 2017-06-02 08:20:58 | Re: BUG #14683: *** glibc detected *** SELECT: double free or corruption |
| Previous Message | Heikki Linnakangas | 2017-06-02 06:24:02 | Re: [PATCH] Fixed malformed error message on malformed SCRAM message. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Kirkwood | 2017-06-02 06:55:46 | Re: logical replication - still unstable after all these months |
| Previous Message | Masahiko Sawada | 2017-06-02 06:31:44 | Re: Why does logical replication launcher set application_name? |