| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken) |
| Date: | 2017-06-02 06:22:58 |
| Message-ID: | 20170602062258.GD1500331@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 26, 2017 at 05:50:45PM +0530, Amit Kapila wrote:
> On Fri, May 26, 2017 at 5:30 AM, Tsunakawa, Takayuki <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
> > I guessed that the reason Noah suggested 1 - 5 seconds of retry is based on the expectation that the address space might be freed by the anti-virus software.
No, I suggested it because I wouldn't seriously consider keeping an
installation where backend start takes 5s. If the address conflicts are that
persistent, I'd fix the bug or switch operating systems. Therefore, we may as
well let it fail at that duration, thereby showing the user what to
investigate. Startup time of 0.2s, on the other hand, is noticeable but
usable; I'd prefer not to fail hard at that duration.
> Noah is also suggesting to have a retry count, read his mail above in
> this thread and refer to his comment ("Thus, measuring time is
> needless complexity; retry count is a suitable proxy.")
Right.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2017-06-02 06:24:02 | Re: [PATCH] Fixed malformed error message on malformed SCRAM message. |
| Previous Message | Tom Lane | 2017-06-02 06:20:00 | Re: [PATCH] Fixed malformed error message on malformed SCRAM message. |