| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Jason Petersen <jason(at)citusdata(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Concurrent ALTER SEQUENCE RESTART Regression |
| Date: | 2017-06-01 21:23:28 |
| Message-ID: | 20170601212327.nknav4z3s4b43lqf@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 2017-06-01 19:08:33 +0200, Petr Jelinek wrote:
> On 01/06/17 16:51, Robert Haas wrote:
> > On Wed, May 31, 2017 at 8:07 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> >> Here's a patch doing what I suggested above. The second patch addresses
> >> an independent oversight where the post alter hook was invoked before
> >> doing the catalog update.
> >
> > 0002 is a slam-dunk. I don't object to 0001 but haven't reviewed it carefully.
> >
>
> I did go over the code (ie didn't do actual testing), and I like it much
> better than the current state. Both in terms of making the behavior more
> consistent and the fact that the code is simpler.
>
> So +1 to go ahead with both patches.
Thanks for the look! I unfortunately forgot to credit you as a
reviewer, sorry for that.
Pushed both.
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-06-02 00:22:39 | Re: Re: BUG #14680: startup process on standby encounter a deadlock of TwoPhaseStateLock when redo 2PC xlog |
| Previous Message | Mike Palmiotto | 2017-06-01 18:13:43 | Re: BUG #14682: row level security not work with partitioned table |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-06-01 21:24:53 | Re: strcmp() tie-breaker for identical ICU-collated strings |
| Previous Message | Jeevan Ladhe | 2017-06-01 21:21:31 | Re: BEFORE trigger can cause undetected partition constraint violation |