| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Michael Meskes <meskes(at)postgresql(dot)org> |
| Cc: | vinayak <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ECPG: pg_type.h file is not synced |
| Date: | 2017-05-30 20:42:42 |
| Message-ID: | 20170530204242.GA11362@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 23, 2017 at 10:25:13AM +0200, Michael Meskes wrote:
> Hi,
>
> > I am looking at ECPG source code. In the "ecpg/ecpglib/pg_type.h" file I
> > have seen following comment:
> >
> > ** keep this in sync with src/include/catalog/pg_type.h*
> >
> > But I think the "ecpg/ecpglib/pg_type.h" file is currently not synced
> > with the above file.
> >
> > I have added the remaining types in the attached patch.
> >
> > I would like to know whether we can add remaining types in the
> > "ecpg/ecpglib/pg_type.h" file or not?
>
> It's not too big a deal as neither of the new OIDs is used in ecpg, but
> still, the file should be up to date.
>
> Thanks for the patch, committed.
Should we add some Makefile magic to make sure they stay in sync?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-05-30 20:49:59 | Re: ECPG: pg_type.h file is not synced |
| Previous Message | Tom Lane | 2017-05-30 20:38:52 | Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x |