From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. |
Date: | 2017-05-17 14:08:47 |
Message-ID: | 20170517140847.lasiafwmsxgzppm6@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> src/bin/pg_basebackup/pg_basebackup.c | 24 +++++++++---------
> src/bin/pg_waldump/pg_waldump.c | 18 ++++++-------
There are some changes here that should be reverted; for instance:
- printf(_(" -c, --checkpoint=fast|spread\n"
- " set fast or spread checkpointing\n"));
+ printf(_(" -c, --checkpoint=fast|spread\n"));
+ printf(_(" set fast or spread checkpointing\n"));
From the translator's point of view the patched version doesn't make
sense because they are two separate strings. In the original, it's a
single translatable string. Particularly in pg_waldump's -p, where a
phrase is now cut in the middle.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-05-17 14:14:29 | Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run. |
Previous Message | Magnus Hagander | 2017-05-17 13:14:37 | Re: [COMMITTERS] pgsql: Tag refs/tags/REL_10_BETA1 was created |
From | Date | Subject | |
---|---|---|---|
Next Message | sveinn.sveinsson | 2017-05-17 14:11:51 | BUG #14657: Server process segmentation fault in v10, May 10th dev snapshot |
Previous Message | Ashutosh Bapat | 2017-05-17 13:24:46 | Re: [POC] hash partitioning |