| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, David Steele <david(at)pgmasters(dot)net>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: snapbuild woes |
| Date: | 2017-05-11 21:54:26 |
| Message-ID: | 20170511215426.5u2itcy5mruo65on@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-05-11 14:51:55 -0700, wrote:
> On 2017-05-08 00:10:12 -0700, Andres Freund wrote:
> > I plan to commit the next pending patch after the back branch releases
> > are cut - it's an invasive fix and the issue doesn't cause corruption
> > "just" slow slot creation. So it seems better to wait for a few days,
> > rather than hurry it into the release.
>
> Now that that's done, here's an updated version of that patch. Note the
> new logic to trigger xl_running_xact's to be logged at the right spot.
> Works well in my testing.
>
> I plan to commit this fairly soon, unless somebody wants a bit more time
> to look into it.
>
> Unless somebody protests, I'd like to slightly revise how the on-disk
> snapshots are stored on master - given the issues this bug/commit showed
> with the current method - but I can see one could argue that that should
> rather be done next release.
As usual I forgot my attachement.
- Andres
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-race-condition-leading-to-hanging-logical-slot-c.patch | text/x-patch | 31.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-05-11 22:12:17 | Re: snapbuild woes |
| Previous Message | Peter Geoghegan | 2017-05-11 21:53:06 | Re: snapbuild woes |