Re: Patch - Tcl 8.6 version support for PostgreSQL

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com>, Paresh More <paresh(dot)more(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch - Tcl 8.6 version support for PostgreSQL
Date: 2017-05-04 14:40:42
Message-ID: 20170504144042.a5gkwadmvz4s2crk@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

> But I agree with Andres' complaint that just duplicating the code isn't
> the best way. The configure script has a loop that's basically like
>
> for f in tclsh tcl tclsh8.6 tclsh86 tclsh8.5 tclsh85 tclsh8.4 tclsh84 tclsh8.3 tclsh83
> do
> ... break if $f is the right one
> done
>
> Seems to me that a similar coding pattern in the MSVC script is a
> reasonable way to go.

Something like the (untested) attached perhaps?

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
msvc-tcl.patch text/plain 1.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-05-04 14:54:05 Re: Patch - Tcl 8.6 version support for PostgreSQL
Previous Message Robert Haas 2017-05-04 14:40:28 Re: transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)