From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: A note about debugging TAP failures |
Date: | 2017-04-22 21:35:09 |
Message-ID: | 20170422213509.rujmkxhrwwecsoop@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2017-04-22 17:25:49 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2017-04-22 16:22:59 -0400, Tom Lane wrote:
> >> In the particular case I was interested in here, the test script thought
> >> everything was successful :-(. I'm working on fixing that little problem,
> >> but I do not believe that the TAP scripts are so bulletproof that there
> >> will never be a need to override their judgment.
>
> > Agreed. If paths are reproducible and cleaned up on next run it's also
> > much less of an issue to just leave them around till the next run.
> > Which we imo also should do for non-failing tmp_check directories.
>
> Mm, not convinced. I think that the delete-on-success behavior was
> intentional, to limit the amount of disk space a buildfarm member would
> consume during a run. I don't mind that being the default, as long as
> there's a way to override it manually.
I don't think there is, currently? I've so far resorted to just adding
some random "foobar" to one of the input files..., or just using
installcheck.
- Andres
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2017-04-22 21:59:11 | Re: A note about debugging TAP failures |
Previous Message | Tom Lane | 2017-04-22 21:25:49 | Re: A note about debugging TAP failures |