Re: src/interfaces/libpq shipping nmake-related Makefiles

On Tue, Apr 11, 2017 at 03:14:23PM +0200, Magnus Hagander wrote:
> On Tue, Apr 11, 2017 at 4:18 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
> wrote:
>
> On Tue, Apr 11, 2017 at 1:45 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Magnus Hagander <magnus(at)hagander(dot)net> writes:
> >>>>> Are these votes for getting rid of both win32.mak and bcc32.mak?
> >
> >> PFA a patch that does this. Did I miss something? :)
> >
> > Perhaps we should get rid of the WIN32_ONLY_COMPILER symbol altogether;
> > given this patch, "#ifdef WIN32_ONLY_COMPILER" could be replaced by
> > "#ifdef _MSC_VER".
>
> That's here in the patch for people wondering:
> -#if defined(_MSC_VER) || defined(__BORLANDC__)
> +#if defined(_MSC_VER)
>  #define WIN32_ONLY_COMPILER
>  #endif
> +1 for the renaming.
>
>
> Ok, since we have two votes for it, I will go ahead and do that (as a separate
> patch pushed together).'

I am fine with removing things, but I do remember one reason the Borland
part was kept is that some tool would only work with the
Borland-compiled library, not gcc or MSVC, but that was long ago.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +