Re: Reversed sync check in pg_receivewal

From: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Reversed sync check in pg_receivewal
Date: 2017-04-11 13:28:09
Message-ID: 20170411132808.GD9058@e733.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Magnus,

> Attached patch reverses the check, and adds a failure message. I'd
> appreciate a quick review in case I have the logic backwards in my head...

Well, I can state that `make check-world` passes on my laptop and that
code seems to be right. However documentation to WalWriteMethod could
probably be improved. Currently there is none.

--
Best regards,
Aleksander Alekseev

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2017-04-11 13:38:07 Re: Reversed sync check in pg_receivewal
Previous Message Michael Paquier 2017-04-11 13:24:45 Re: Reversed sync check in pg_receivewal