| From: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GCC 7 warnings |
| Date: | 2017-04-10 15:35:24 |
| Message-ID: | 20170410153524.GA13447@e733.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Peter,
> c) Expand the target buffer sizes until the warning goes away. (Sample
> patch attached.)
I personally think it's a great patch. Unfortunately I don't have GCC
7.0 right now but at least it doesn't break anything on 6.3.1. Since
there is no rush I would suggest to add an entry to the next commitfest,
so this patch wouldn't accidentally be lost.
As a side node I believe it would be great to replace all sprintf calls
to snprintf just to be on a safe side. IIRC we did something similar to
str* procedures not a long time ago. Unless there are any objections
regarding this idea I'm willing to write such a patch.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-04-10 15:38:05 | Re: Merge join for GiST |
| Previous Message | Robert Haas | 2017-04-10 15:34:22 | Re: RMT: Use Visual Studio 2015 for Compiling and linking the Windows version in PG10 |