From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
Cc: | 'Craig Ringer' <craig(dot)ringer(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: Supporting huge pages on Windows |
Date: | 2017-04-05 06:58:16 |
Message-ID: | 20170405065816.e3t4ta6mxzypkhj7@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2017-04-05 04:25:41 +0000, Tsunakawa, Takayuki wrote:
> From: Craig Ringer [mailto:craig(dot)ringer(at)2ndquadrant(dot)com]
> > On 5 April 2017 at 10:37, Tsunakawa, Takayuki
> > <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
> >
> > OTOH, I tried again to leave the DISABLE_MAX_PRIVILEGE as is and add Lock
> > Pages in Memory, using the attached pg_ctl.c. Please see
> > EnableLockPagesPrivilege() and its call site. But pg_ctl -w start fails
> > emitting the following message:
> >
> > That won't work. You'd have to pass 0 to the flags of CreateRestrictedToken
> > and instead supply a PrivilegesToDelete array.
> > You'd probably GetTokenInformation and AND with a mask of ones you wanted
> > to retain.
>
> Uh, that's inconvenient. We can't determine what privileges to delete, and we must be aware of new privileges added in the future version of Windows.
>
> Then, I have to say the last patch (v12) is the final answer.
As I asked before, why can't we delete all privs and add the explicitly
needed once back (using AdjustTokenPrivileges)?
- Andres
From | Date | Subject | |
---|---|---|---|
Next Message | Vaishnavi Prabakaran | 2017-04-05 07:00:42 | Re: PATCH: Batch/pipelining support for libpq |
Previous Message | Noah Misch | 2017-04-05 06:56:56 | Re: [pgsql-www] Small issue in online devel documentation build |