Re: parallel bitmapscan isn't exercised in regression tests

From: Andres Freund <andres(at)anarazel(dot)de>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: parallel bitmapscan isn't exercised in regression tests
Date: 2017-04-03 17:52:12
Message-ID: 20170403175212.olsuo2zwddwf47lm@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017-04-01 17:23:04 +0530, Dilip Kumar wrote:
> On Sat, Apr 1, 2017 at 12:16 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > Hi,
> >
> > The parallel code-path isn't actually exercised in the tests added in
> > [1], as evidenced by [2] (they just explain). That imo needs to be
> > fixed.
>
> Thanks for reporting. Attached patch fixes that.

That's better than before, but I'd appreciate working on a bit more
coverage. E.g. rescans probably aren't exercised in that test, right?

If you have time & energy, it'd also be good to expand the tests to
cover the prefetching logic - it's quite bad that it's currently not
tested at all :(

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-04-03 17:53:48 Re: parallel explain analyze support not exercised
Previous Message anant khandelwal 2017-04-03 17:48:16 Fwd: GSoC 2017 Proposal for "Explicitly support predicate locks in index access methods besides btree"