| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: brin autosummarization -- autovacuum "work items" |
| Date: | 2017-03-31 18:49:19 |
| Message-ID: | 20170331184919.6eh3hdgskxjcnppt@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here's a version of this patch which I consider final.
Thanks for your tips on using DSA. No crashes now.
I am confused about not needing dsa_attach the second time around. If I
do that, the dsa handle has been 0x7f'd, which I don't understand since
it is supposed to be allocated in TopMemoryContext. I didn't dig too
deep to try and find what is causing that behavior. Once we do, it's
easy to remove the dsa_detach/dsa_attach calls.
I added a new SQL-callable function to invoke summarization of an
individual page range. That is what I wanted to do in vacuum (rather
than a scan of the complete index), and it seems independently useful.
I also removed the behavior that on index creation the final partial
block range is always summarized. It's pointless.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| brin-autosummarize-2.patch | text/plain | 31.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-03-31 18:54:40 | Re: Allow to specify #columns in heap/index_form_tuple |
| Previous Message | Tom Lane | 2017-03-31 18:48:05 | Re: bumping HASH_VERSION to 3 |