| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: WIP: [[Parallel] Shared] Hash |
| Date: | 2017-03-31 18:35:16 |
| Message-ID: | 20170331183516.yhumtqzfvhpwlsx7@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Thomas,
On 2017-03-31 17:53:12 +1300, Thomas Munro wrote:
> Thanks very much to Rafia for testing, and to Andres for his copious
> review feedback. Here's a new version. Changes:
I've not looked at that aspect, but one thing I think would be good is
to first add patch that increases coverage of nodeHash[join].c to nearly
100%. There's currently significant bits of nodeHash.c that aren't
covered (skew optimization, large tuples).
https://coverage.postgresql.org/src/backend/executor/nodeHash.c.gcov.html
https://coverage.postgresql.org/src/backend/executor/nodeHashjoin.c.gcov.html
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-03-31 18:38:01 | Re: Somebody has not thought through subscription locking considerations |
| Previous Message | Tom Lane | 2017-03-31 18:32:50 | Re: Allow to specify #columns in heap/index_form_tuple |