Re: pgsql: Remove objname/objargs split for referring to objects

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Remove objname/objargs split for referring to objects
Date: 2017-03-15 15:18:29
Message-ID: 20170315151829.bhxsvrp75xdxhm3n@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut wrote:
> Remove objname/objargs split for referring to objects

I don't know if this is the guilty commit, but I'm now getting these
compiler warnings:

/pgsql/source/master/src/backend/catalog/objectaddress.c: In function 'get_object_address':
/pgsql/source/master/src/backend/catalog/objectaddress.c:1624:33: warning: 'typenames[1]' may be used uninitialized in this function [-Wmaybe-uninitialized]
ereport(ERROR,
^
/pgsql/source/master/src/backend/catalog/objectaddress.c:1578:8: note: 'typenames[1]' was declared here
char *typenames[2];
^
/pgsql/source/master/src/backend/catalog/objectaddress.c:1624:33: warning: 'typenames[0]' may be used uninitialized in this function [-Wmaybe-uninitialized]
ereport(ERROR,
^
/pgsql/source/master/src/backend/catalog/objectaddress.c:1578:8: note: 'typenames[0]' was declared here
char *typenames[2];
^

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2017-03-15 15:20:14 pgsql: Bump catversion for MACADDR8
Previous Message Stephen Frost 2017-03-15 15:16:44 pgsql: Add support for EUI-64 MAC addresses as macaddr8

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2017-03-15 15:20:07 Re: Re: [GSOC 17] Eliminate O(N^2) scaling from rw-conflict tracking in serializable transactions
Previous Message Robert Haas 2017-03-15 15:12:37 Re: Write Ahead Logging for Hash Indexes