| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Need a builtin way to run all tests faster manner |
| Date: | 2017-03-14 20:31:08 |
| Message-ID: | 20170314203108.xb3m7ihxsk3fztlb@alap3.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-03-13 00:35:06 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2017-03-11 22:14:07 -0500, Tom Lane wrote:
> >> This looks generally sane to me, although I'm not very happy about folding
> >> the "$(MKDIR_P) output_iso" call into pg_isolation_regress_check --- that
> >> seems weird and unlike the way it's done for the regular regression test
> >> case.
>
> > Yea, not super happy about that either - alternatively we could fold it
> > into pg_regress.
>
> Yeah, teaching pg_regress to auto-create the --temp-instance directory
> seems perfectly sane from here.
I was thinking about outputdir, not temp-instance. The latter is
already created:
/* make the temp instance top directory */
make_directory(temp_instance);
Attached is an updated patch that creates outputdir if necessary. This
is possibly going to trigger a time-to-check-time-to-use coverity
warning, but the rest of pg_regress does if(!exists) mkdir() type logic,
so I did the same.
Besides the pg_regress change, the only thing I've changed is to remove
the in-line "$(MKDIR_P) output_iso && \".
- Andres
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Improve-isolation-regression-tests-infrastructure.patch | text/x-patch | 9.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Janes | 2017-03-14 20:39:44 | Re: scram and \password |
| Previous Message | Peter Geoghegan | 2017-03-14 20:14:12 | Re: Patch: Write Amplification Reduction Method (WARM) |