Re: [COMMITTERS] pgsql: Add amcheck extension to contrib.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: Add amcheck extension to contrib.
Date: 2017-03-14 20:09:17
Message-ID: 20170314200916.2a3qzm746crgi4qk@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2017-03-13 14:09:39 -0700, Andres Freund wrote:
> Hi,
>
> On 2017-03-13 15:45:01 -0400, Tom Lane wrote:
> > I could be wrong, but the most obvious explanation for this failure is
> > that autovacuum had a lock on the table or index when we looked.
> > Even if that isn't why axolotl failed in this particular case, I think
> > it's dead certain that we will see such failures from time to time
> > if this test script isn't tightened up. IIUC what the test is trying
> > to look for, I think adding "AND pid = pg_backend_pid()" to this query
> > would be an appropriate fix.
>
> Yes, that sounds reasonable. Will do in a bit. Thanks for noticing.

Pushed.

- Andres

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2017-03-14 21:38:07 pgsql: Add option to control snapshot export to CREATE_REPLICATION_SLOT
Previous Message Andres Freund 2017-03-14 20:09:12 pgsql: amcheck: Harden tests against concurrent autovacuums.

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2017-03-14 20:14:12 Re: Patch: Write Amplification Reduction Method (WARM)
Previous Message Robert Haas 2017-03-14 19:52:10 Re: exposing wait events for non-backends (was: Tracking wait event for latches)