Re: pgsql: contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.
Date: 2017-03-10 04:00:18
Message-ID: 20170310040018.vcsp6rsh5baqngie@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2017-03-10 03:55:50 +0000, Tom Lane wrote:
> contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.
>
> Per buildfarm. Maybe some of the other xmin variables in snapmgr.h
> ought to get this too, but for the moment I'm just interested in
> un-breaking the buildfarm.

Heh, I just wanted to push a patch removing the assertion because it
doesn't add that much. There's imo no reason not to mark the variable
PGDLLIMPORT, so I'm good with this too.

- Andres

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-03-10 04:04:32 pgsql: amcheck: editorialize variable name & comment.
Previous Message Tom Lane 2017-03-10 03:55:50 pgsql: contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.