| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new gcc 7.0.1 warnings |
| Date: | 2017-03-08 16:33:58 |
| Message-ID: | 20170308163358.omws55zq2xr4lrfw@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pavel Stehule wrote:
> 2017-02-18 18:35 GMT+01:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>
> > Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> > Do the warnings go away if you add some explicit guard to the precision
> > variable, say like this:
> >
> > {
> > int ndig = DBL_DIG + extra_float_digits;
> >
> > if (ndig < 1)
> > ndig = 1;
> > + if (ndig > 50)
> > + ndig = 50;
>
> This fix doesn't help
Ahh, so this is why you had this change in the xmltable patch once!
Heh. Please be more careful.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2017-03-08 16:37:27 | Re: adding an immutable variant of to_date |
| Previous Message | Alvaro Herrera | 2017-03-08 16:32:19 | Re: patch: function xmltable |