From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_restore is broken on 9.2 version. |
Date: | 2017-02-07 14:51:04 |
Message-ID: | 20170207145104.GW9812@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Greetings,
* Rushabh Lathia (rushabh(dot)lathia(at)gmail(dot)com) wrote:
> Commit c59a1a89035674c6efacc596d652528cebba37ec don't allow non-positive
> number
> of jobs. Now on 9.2 number of jobs get assigned to opts->number_of_jobs. If
> user don't specify any value -j then default value will be always 0. Which
> will
> lead to the "invalid number of parallel jobs" error.
>
> if (opts->number_of_jobs <= 0)
> {
> fprintf(stderr, _("%s: invalid number of parallel jobs\n"),
> progname);
> exit(1);
> }
>
> Please find attach patch to initialize default value for number of jobs to
> 1.
Ugh. This is what I get for thinking that our regression tests actually
test even the basic things.
That fix should go into NewRestoreOptions() where the other not-zero
settings go.
I'll fix it here in a few.
Thanks!
Stephen
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2017-02-07 14:53:09 | Re: DROP SUBSCRIPTION and ROLLBACK |
Previous Message | Tom Lane | 2017-02-07 14:42:27 | Re: 'text' instead of 'unknown' in Postgres 10 |