| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Compiler warning |
| Date: | 2016-12-24 00:21:43 |
| Message-ID: | 20161224002143.GA3224@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I am seeing this compiler warning in the 9.4 branch:
9.4: basebackup.c:1284:6: warning: variable 'wait_result' set but not used [-Wunused-but-set-variable]
This is on Debian Jessie with gcc version 4.9.2. It is from this commit:
commit f6508827afe76b2c3735a9ce073620e708d60c79
Author: Magnus Hagander <magnus(at)hagander(dot)net>
Date: Mon Dec 19 10:11:04 2016 +0100
Fix base backup rate limiting in presence of slow i/o
When source i/o on disk was too slow compared to the rate limiting
specified, the system could end up with a negative value for sleep that
it never got out of, which caused rate limiting to effectively be
turned off.
Discussion: https://postgr.es/m/CABUevEy_-e0YvL4ayoX8bH_Ja9w%2BBHoP6jUgdxZuG2nEj3uAfQ%40mail.gmail.com
Analysis by me, patch by Antonin Houska
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2016-12-24 00:25:30 | Re: Clarifying "server starting" messaging in pg_ctl start without --wait |
| Previous Message | Tom Lane | 2016-12-24 00:12:51 | Re: Time to retire Windows XP buildfarm host? |