From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Minor correction in alter_table.sgml |
Date: | 2016-12-22 14:17:59 |
Message-ID: | 20161222141759.z6lkotsyd4d7fdgg@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Stephen Frost wrote:
> Tom,
>
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> > BTW, so far as the HEAD version of this patch goes, I notice that
> > ATTACH PARTITION and DETACH PARTITION were recently added to the
> > list of exceptions. But they're not exceptions according to this
> > wording: they act on more than one table (the parent and the
> > partition), no? So we could simplify the sentence some more by
> > removing them again.
>
> I had considered removing those but thought that some users might think
> that they're only "altering" one table and therefore felt it made sense
> to keep those explicitly listed.
I agree with Stephen; it's not crystal clear from the user's POV that
the command is altering two tables. It's worth mentioning this
explicitly; otherwise this is just a documented gotcha.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-12-22 14:49:04 | Re: Minor correction in alter_table.sgml |
Previous Message | Stephen Frost | 2016-12-22 14:10:32 | Re: Minor correction in alter_table.sgml |