From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: Re: [COMMITTERS] pgsql: Permit dump/reload of not-too-large >1GB tuples |
Date: | 2016-12-09 14:51:47 |
Message-ID: | 20161209145147.d5m4bo7b2b2gy5cl@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera wrote:
> Tom Lane wrote:
> > Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > > Permit dump/reload of not-too-large >1GB tuples
> >
> > I apologize for not having paid close enough attention earlier, but:
> > this patch is absolutely unacceptable for the back branches and MUST
> > be reverted there. Adding another field to StringInfoData is an ABI
> > change that will certainly break large numbers of extensions. We
> > can't expect those to get recompiled for minor releases.
>
> Oh, I see the problem now -- it can (and frequently is) stack allocated,
> not just palloc'ed using the StringInfo api, and changing the size
> breaks that. Rats. I'll revert tomorrow.
Done.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2016-12-09 15:44:28 | pgsql: Fix crasher bug in array_position(s) |
Previous Message | Peter Geoghegan | 2016-12-08 21:08:21 | Re: pgsql: Fix accounting of memory needed for merge heap. |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2016-12-09 14:52:09 | Re: tzdata 2016j |
Previous Message | Alvaro Herrera | 2016-12-09 14:51:41 | Re: pg_dump / copy bugs with "big lines" ? |