| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Joshua Drake <jd(at)commandprompt(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Mail thread references in commits |
| Date: | 2016-12-01 23:10:55 |
| Message-ID: | 20161201231055.rkih6vrgsnhgmx3m@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016-12-01 18:05:19 -0500, Tom Lane wrote:
> ... the shortener isn't really doing anything for us. You end up with a
> line longer than 80 characters with message-IDs generated by either gmail
> or the bug report form, for instance these examples from recent commits:
Still seems quite useful to me. I don't really see much argument
against.
This:
> Discussion: https://postgr.es/m/20161128182113.6527.58926@wrigleys.postgresql.org
> Discussion: https://postgr.es/m/CA+renyUEE29=X01JXdz8_TQvo6n9=2XoEBBRnQ8rkLyr+kjPxQ@mail.gmail.com
still looks better than:
> Discussion: http://www.postgresql.org/message-id/20161128182113.6527.58926@wrigleys.postgresql.org
> Discussion: http://www.postgresql.org/message-id/CA+renyUEE29=X01JXdz8_TQvo6n9=2XoEBBRnQ8rkLyr+kjPxQ@mail.gmail.com
and I see little downside. If we can't keep the first stable, we can't
keep the second one stable either.
> Another convention that apparently needs to be discussed is whether or
> not to point at a whole thread, as in this example from yesterday:
>
> Discussion: http://www.postgresql.org/message-id/flat/0A3221C70F24FB45833433255569204D1F5EE995(at)G01JPEXMBYT05/
>
> I'm kind of -1 on that; it's adding 5 characters for not much.
-1 on that too.
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-12-01 23:12:34 | Re: Mail thread references in commits |
| Previous Message | Tom Lane | 2016-12-01 23:05:19 | Re: Mail thread references in commits |