Re: Mail thread references in commits

Robert Haas wrote:
> On Thu, Nov 17, 2016 at 4:06 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > On November 17, 2016 1:02:38 PM PST, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> >>I love seeing references to email threads in commit messages. It would
> >>make them a lot friendlier though if a full http URL were included
> >>instead of just a Message-ID, i.e. instead of <foo1234(at)bar(dot)com> put
> >><https://www.postgresql.org/message-id/foo1234@bar.com>. I know this is
> >>
> >>a bit more trouble. but not that much, and it would make it very easy
> >>to
> >>follow with just a mouse click.
> >
> > They're really hard to read though, because lines with e.g. gmail message IDs get very long even without that prefix. Do you look at these in the e-mail or gitweb?
>
> Yeah. I really hate having commit messages that are more than 70-75
> characters wide, and a message-ID takes you well above that. I wish
> we had something like archives.postgresql.org/sha/5bcd5142 instead of
> basing everything off the message-ID.

The advantage of using the message-ID is that you can use it while
offline too (very common among this crowd to do stuff while on planes,
since conferences and such are so frequent now), so I wouldn't make that
trade.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services