Re: Document how to set up TAP tests for Perl 5.8.8

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: craig(at)2ndquadrant(dot)com
Cc: michael(dot)paquier(at)gmail(dot)com, noah(at)leadboat(dot)com, pgsql-hackers(at)postgresql(dot)org, peter(dot)eisentraut(at)2ndquadrant(dot)com
Subject: Re: Document how to set up TAP tests for Perl 5.8.8
Date: 2016-11-17 03:16:01
Message-ID: 20161117.121601.67009057.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

At Thu, 17 Nov 2016 11:59:02 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <20161117(dot)115902(dot)224922490(dot)horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
> My only concern is the fact that 'make check-world' runs the TAP
> tests as a part if --enable-tap-tests (according to
> release-9.4.sgml, but I haven't done by myself.). I completely
> agree to you if it didn't run as a part of top-level 'make <some
> kind of check>'.

Hmm. I notice that older perls may reject installation of TAP. If
that's true, no check needed but a description also might be
needed to --enable-tap-tests. Or, might not be needed since
anyway it fails for the older versions.

diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index 296611d..58459e5 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -1285,9 +1285,11 @@ su - postgres
<term><option>--enable-tap-tests</option></term>
<listitem>
<para>
- Enable tests using the Perl TAP tools. This requires a Perl
- installation and the Perl module <literal>IPC::Run</literal>.
- <![%standalone-ignore;[See <xref linkend="regress-tap"> for more information.]]>
+ Enable tests using the Perl TAP tools. This requires a Perl (5.8.8
+ or later) installation and the Perl
+ module <literal>IPC::Run</literal>.
+ <![%standalone-ignore;[See <xref linkend="regress-tap"> for more
+ information.]]>
</para>
</listitem>
</varlistentry>

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mithun Cy 2016-11-17 03:24:46 Re: Improve OOM handling in pg_locale.c
Previous Message Tom Lane 2016-11-17 03:14:47 Re: pg_dump versus rules, once again