Re: Unused variable in postgres_fdw/deparse.c

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: ashutosh(dot)bapat(at)enterprisedb(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Unused variable in postgres_fdw/deparse.c
Date: 2016-10-27 00:06:58
Message-ID: 20161027.090658.213663921.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

At Wed, 26 Oct 2016 11:00:17 +0530, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote in <CAFjFpRcFoBn0cd1hMueYtkaL+x_KcBD4kJcuvh4jqKtbviCvDw(at)mail(dot)gmail(dot)com>
> On Wed, Oct 26, 2016 at 6:19 AM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Thanks for the patch and sorry for missing this in the review. I
>
> The patch applies but seems to have a trailing white space.

Oops. My 'git commit' has a hook to warn such mistakes but it is
just made by 'git diff'. Automatic measure made me forget to keep
alert:p

> patch -p1 < /mnt/hgfs/tmp/postgre_fdw_delete_unused_var.patch
> (Stripping trailing CRs from patch.)
> patching file contrib/postgres_fdw/deparse.c
> But that's removed my "patch" command.
>
> It compiles cleanly and make check in contrib/postgres_fdw does not
> show any failure.

Thanks for confirmation.

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2016-10-27 00:08:32 Re: Unused variable in postgres_fdw/deparse.c
Previous Message Tomas Vondra 2016-10-26 22:45:11 Re: Speed up Clog Access by increasing CLOG buffers