From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
Date: | 2016-10-24 19:11:45 |
Message-ID: | 20161024191145.GQ13284@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Fabien COELHO wrote:
> >> I find it annoying that "//" comments are not supported, or having to
> >> declare variables at the beginning of a block instead of when first used...
>
> > I think some c99 features would be nice (variadic macros for one), but
> > those particular two get a big "meh" from me.
>
> Yeah. Personally, I'd want to continue the rule against // comments just
> as a matter of maintaining stylistic consistency. Code that's got a
> random mishmash of // and /* comments looks messy, if you ask me.
+1
> An alternative that would be worth considering is to adopt a uniform
> rule of // for line-ending comments and /* for all other uses. We'd
> have to teach pgindent about that, and I dunno how hard that is.
I'm not sure it's worth the resulting mess.
Thanks!
Stephen
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2016-10-24 19:51:32 | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
Previous Message | Tom Lane | 2016-10-24 19:03:19 | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2016-10-24 19:33:35 | Re: PL/Python adding support for multi-dimensional arrays |
Previous Message | Tom Lane | 2016-10-24 19:03:19 | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |