| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christoph Berg <myon(at)debian(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Renaming of pg_xlog and pg_clog |
| Date: | 2016-10-24 15:06:27 |
| Message-ID: | 20161024150627.GB11907@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 24, 2016 at 11:59:42AM -0300, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > On Sat, Oct 22, 2016 at 11:18:28PM +0300, Greg Stark wrote:
>
> > > I think the apt-get behaviour was specifically designed to ensure it
> > > couldn't easily be put into a script which I would have said was
> > > desirable -- except I suspect there are situations where Postgres
> > > database scripts need to do a resetxlog. I'm not sure I can think of
> > > any examples offhand but I wouldn't be too surprised.
> >
> > Yes, pg_upgrade has eight calls to pg_resetxlog to set various value.
>
> There is one difference though, which is that the really destructive
> use of pg_resetxlog is the one that removes pg_xlog files. The other
> uses that simply set flags in the control file are not as bad -- you can
> simply go back to what the original value was. I think we would only
> need the obnoxious string requirement in the most dangerous mode.
>
> Alternatively, we could separate the tool in two different executables.
OK, but we are going need to document that this special flag is only
needed for certain option uses.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Albe Laurenz | 2016-10-24 15:35:49 | Re: Add PGDLLEXPORT to PG_FUNCTION_INFO_V1 |
| Previous Message | Alvaro Herrera | 2016-10-24 14:59:42 | Re: Renaming of pg_xlog and pg_clog |