| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: incorrect libpq comment |
| Date: | 2016-10-19 17:35:52 |
| Message-ID: | 20161019173552.GV5087@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 19, 2016 at 01:16:28PM -0400, Robert Haas wrote:
> Bruce's commit 5d305d86bd917723f09ab4f15c075d90586a210a back in April
> of 2014 includes this change:
>
> /* See PQconnectPoll() for how we use 'int' and not 'pgsocket'. */
> - int sock; /* Unix FD for socket, -1 if not connected */
> + pgsocket sock; /* FD for socket, PGINVALID_SOCKET if
> unconnected */
>
> I suppose Bruce must have overlooked the fact that the comment on the
> previous line is now false. I think we should remove it, because it
> makes no sense to say how we are using 'int' rather than 'pgsocket'
> when in fact we are not using 'int' any more.
Agreed.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-10-19 17:41:50 | Re: Portable check for unportable <ctype.h> macro usage |
| Previous Message | Bruce Momjian | 2016-10-19 17:34:41 | Re: Move pg_largeobject to a different tablespace *without* turning on system_table_mods. |