| From: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Remove redundant if clause in standbydesc.c |
| Date: | 2016-09-23 09:54:31 |
| Message-ID: | 20160923095431.GD1238@e733 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> > Very simple small patch - see attachment.
>
> /* not expected, but print something anyway */
> else if (msg->id == SHAREDINVALRELMAP_ID)
> - appendStringInfoString(buf, " relmap");
> - else if (msg->id == SHAREDINVALRELMAP_ID)
> appendStringInfo(buf, " relmap db %u", msg->rm.dbId);
>
> Looking at inval.c, dbId can be InvalidOid.
Frankly I'm not very familiar with this part of code. InvalidOid is just
zero. Does it create some problem in this case?
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2016-09-23 09:57:54 | Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission denied” |
| Previous Message | Michael Paquier | 2016-09-23 09:35:01 | Re: [PATCH] Remove redundant if clause in standbydesc.c |