| From: | David Fetter <david(at)fetter(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New SQL counter statistics view (pg_stat_sql) |
| Date: | 2016-09-21 16:22:59 |
| Message-ID: | 20160921162259.GA22059@fetter.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 21, 2016 at 11:25:14AM -0400, Peter Eisentraut wrote:
> On 9/14/16 4:01 PM, Robert Haas wrote:
> > I think it is not a good idea to make the command names used here the
> > plural forms of the command tags. Instead of "inserts", "updates",
> > "imports", etc. just use "INSERT", "UPDATE", "IMPORT". That's simpler
> > and less error prone - e.g. you won't end up with things like
> > "refreshs", which is not a word.
>
> How about having the tag not be a column name but a row entry. So you'd
> do something like
>
> SELECT * FROM pg_stat_sql WHERE tag = 'ALTER VIEW';
+1 for this. It's MUCH easier to deal with changes in row counts than
changes in row type.
Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2016-09-21 16:24:21 | pgsql: pg_ctl: Detect current standby state from pg_control |
| Previous Message | Jeff Janes | 2016-09-21 16:08:50 | Re: pageinspect: Hash index support |