Re: mdtruncate leaking fd.c handles?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: mdtruncate leaking fd.c handles?
Date: 2016-09-08 22:50:42
Message-ID: 20160908225042.uzcursaj6ifvoif4@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2016-09-08 18:39:56 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Am I missing something or is md.c:mdtruncate() leaking open files?
>
> Yeah, I think you're right.
>
> > This only really matters for VACUUM truncate and ON COMMIT TRUNCATE temp
> > table truncation afaics.
>
> Also, you'd need a table > 1GB to leak anything at all, which probably
> helps explain why it hasn't been noticed.

Heh, this bug is of some older vintage... Appears to originate in
1a5c450f3024ac57cd6079186c71b3baf39e84eb - before that we did a
FileUnlink(), which includes a FileClose().

Will fix.

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2016-09-08 22:59:26 Re: Logical Replication WIP
Previous Message Tom Lane 2016-09-08 22:39:56 Re: mdtruncate leaking fd.c handles?