From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: Default make target in test modules |
Date: | 2016-09-08 16:47:40 |
Message-ID: | 20160908164740.GA31913@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> I happened to notice that if you type "make" in
> src/test/modules/test_pg_dump, you will get a "make check" action
> not "make all". I hope this is just somebody being thoughtless
> about Makefile ordering and not an intentional override of the
> default make target. If the latter, I beg to differ about it
> being a good idea.
Strange. Don't all these makefiles depend on the pgxs stuff emitting
something sane, which would have "all" as the first one? ... Ooh, I see
that test_pg_dump adds "check" before including pgxs, which is what
AFAICS causes the problem.
I suppose this is a very easy mistake to make -- but also fortunately an
easy one to correct. Do you want me to fix the affected modules?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-09-08 16:48:33 | Re: Re: [COMMITTERS] pgsql: Make initdb's suggested "pg_ctl start" command line more reliabl |
Previous Message | Tom Lane | 2016-09-08 16:36:02 | Default make target in test modules |