From: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Subject: | Re: Proposal for changes to recovery.conf API |
Date: | 2016-09-06 07:06:55 |
Message-ID: | 20160906070655.GA18005@toroid.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At 2016-09-06 14:40:54 +0900, michael(dot)paquier(at)gmail(dot)com wrote:
>
> my best advice here is to make all those recovery_target_* parameters
> PGC_POSTMASTER so as they are loaded only once when the server starts,
> and then we define the recovery target type used in the startup
> process instead of trying to do so at GUC level.
I understand your approach in light of the GUC code, but I see things a
bit differently—the complexity comes largely from the specific handling
of recovery_target. I'll try to come up with a way to do it better. If
not, we have your suggestion to fall back on.
> + else if (recovery_target_lsn != 0)
> + recovery_target = RECOVERY_TARGET_LSN;
> This needs to check for InvalidXLogRecPtr.
Of course, thanks. Fixed locally in all the relevant places. Will repost
whenever there are other substantive changes.
-- Abhijit
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2016-09-06 07:08:52 | Re: Parallel tuplesort (for parallel B-Tree index creation) |
Previous Message | Simon Riggs | 2016-09-06 06:59:52 | Re: Speedup twophase transactions |