Re: [PATCH] COPY vs \copy HINT

From: Christoph Berg <myon(at)debian(dot)org>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] COPY vs \copy HINT
Date: 2016-09-02 09:05:08
Message-ID: 20160902090508.avbmkfodpe72vmjw@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Re: Craig Ringer 2016-09-02 <CAMsr+YFr6Sk=bbU2yCORN7z9foHF0cqx29vk5B49DswQ6EkVxg(at)mail(dot)gmail(dot)com>
> I thought about that but figured it didn't really matter too much,
> when thinking about examples like
>
> # COPY batch_demo FROM '/root/secret.csv' WITH (FORMAT CSV);
> ERROR: could not open file "/root/secret.csv" for reading: Permission denied
>
> or whatever, where the user doesn't understand why they can't read the
> file given that their local client has permission to do so.
>
> I don't feel strongly about this and think that the error on ENOENT is
> by far the most important, so I'll adjust it per your recommendation.

Couldn't you just add EACCESS to the check as well?

> > 3. As for the wording, maybe you could do it like this:
> >
> > HINT: COPY copies to[from] a file on the PostgreSQL server, not on the
> > client. You may want a client-side facility such as psql's \copy.
> >
> > That avoids trying to invent a name for other implementations.
>
> I like that wording a lot more, thanks. Adopted.

Same here, thanks!

Christoph

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2016-09-02 09:07:06 Re: Let file_fdw access COPY FROM PROGRAM
Previous Message Robert Haas 2016-09-02 09:01:28 Re: less expensive pg_buffercache on big shmem