Re: pg_bsd_indent - improvements around offsetof and sizeof

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_bsd_indent - improvements around offsetof and sizeof
Date: 2016-08-22 21:05:40
Message-ID: 20160822210540.GA13292@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 16, 2016 at 11:47:09AM -0700, Andres Freund wrote:
> On 2016-08-15 18:09:02 +0000, Piotr Stefaniak wrote:
> > There are more fixes I intend to do, of which the most relevant for
> > Postgres are:
> > 1) fixing "function pointer typedef formatting"
>
> This alone would warrant a bottle of something rather expensive.

Agreed. I was kind of hoping we could use this for the pgindent run we
just did, but that is being done just before 9.6 final, which seems too
close. I suggest we run it once everything is ready, and run it on all
back-branches so we can backpatch things. The ideal time would probably
be right after we have done minor releases. The problem is that this is
going to break queued-up patches, so maybe it has to be done right
before 10.0 beta, and again, to all back branches too.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2016-08-22 21:20:52 Re: sslmode=require fallback
Previous Message Andres Freund 2016-08-22 21:00:45 Re: [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables)