Re: errno clobbering in reorderbuffer

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: errno clobbering in reorderbuffer
Date: 2016-08-18 22:12:00
Message-ID: 20160818221200.md6vnxvhzll2qp53@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2016-08-18 19:06:02 -0300, Alvaro Herrera wrote:
> While researching a customer issue with BDR I noticed that one ereport()
> call happens after clobbering errno, leading to the wrong strerror being
> reported. This patch fixes it by saving before calling
> CloseTransientFile and restoring afterwards.
>
> I also threw in a missing errcode I noticed while looking for similar
> problems in the same file.
>
> This is to backpatch to 9.4.

Makes sense - you're doing that or shall I?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-08-18 22:17:25 Re: errno clobbering in reorderbuffer
Previous Message Peter Eisentraut 2016-08-18 22:11:34 Re: drop src/backend/port/darwin/system.c ?