Re: heap_xlog_lock forgets to reset HEAP_XMAX_INVALID

Andres Freund wrote:
> On 2016-07-15 17:23:57 -0400, Alvaro Herrera wrote:

> > Maybe we should change fix_infomask_from_infobits() to reset
> > HEAP_XMAX_BITS | HEAP_MOVED too (and HEAP_KEYS_UPDATED I suppose), to
> > avoid doing it in each callsite.
>
> Yea, I was thinking of that as well. But there's code like
> htup->t_infomask &= ~(HEAP_XMAX_BITS | HEAP_MOVED);
> htup->t_infomask2 &= ~HEAP_KEYS_UPDATED;
> if (hot_update)
> HeapTupleHeaderSetHotUpdated(htup);
> else
> HeapTupleHeaderClearHotUpdated(htup);
> fix_infomask_from_infobits(xlrec->old_infobits_set, &htup->t_infomask,
> &htup->t_infomask2);
>
> so I'd rather only clean this up in master.

Mumble. I don't see any way that this would matter, but I don't object
to doing the cleanup in master only.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services