| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Marc Cousin <marc(dot)cousin(at)dalibo(dot)com> |
| Subject: | Re: Issue with bgworker, SPI and pgstat_report_stat |
| Date: | 2016-07-07 18:06:56 |
| Message-ID: | 20160707180656.fu6iojkket5o43nb@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016-07-07 14:04:36 -0400, Robert Haas wrote:
> On Thu, Jul 7, 2016 at 1:52 PM, Julien Rouhaud
> <julien(dot)rouhaud(at)dalibo(dot)com> wrote:
> > Should a bgworker modifing data have to call pgstat_report_stat() to
> > avoid this problem? I don't find any documentation suggesting it, and it
> > seems that worker_spi (used as a template for this bgworker and I
> > suppose a lot of other one) is also affected.
>
> That certainly seems like the simplest fix. Not sure if there's a better one.
I think a better fix would be to unify the startup & error handling
code. We have way to many slightly diverging copies. But that's a bigger
task, so I'm not protesting against making a more localized fix.
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2016-07-07 18:10:51 | Re: MVCC overheads |
| Previous Message | Peter Geoghegan | 2016-07-07 18:05:48 | Re: Bug in batch tuplesort memory CLUSTER case (9.6 only) |