From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | Peter Geoghegan <pg(at)heroku(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Bug in batch tuplesort memory CLUSTER case (9.6 only) |
Date: | 2016-07-07 07:34:02 |
Message-ID: | 20160707073402.GA1690813@tornado.leadboat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
This PostgreSQL 9.6 open item is past due for a status update.
On Sat, Jul 02, 2016 at 08:47:20PM -0700, Peter Geoghegan wrote:
> On Sat, Jul 2, 2016 at 3:17 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > In the interest of clarity, I was not intending to say that there
> > should be a regression test in the patch. I was intending to say that
> > there should be a test case with the bug report. I'm not opposed to
> > adding a regression test, and I like the idea of attempting to do so
> > while requiring only a relatively small amount of data by changing
> > maintenance_work_mem, but that wasn't the target at which I was
> > aiming. Nevertheless, carry on.
>
> How do you feel about adding testing to tuplesort.c not limited to
> hitting this bug (when Valgrind memcheck is used)?
Sounds great, but again, not in the patch fixing this bug.
> Are you satisfied that I have adequately described steps to reproduce?
I can confirm that (after 62 minutes) your test procedure reached SIGSEGV
today and then completed successfully with your patch.
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro HORIGUCHI | 2016-07-07 07:41:25 | Re: Header and comments describing routines in incorrect shape in visibilitymap.c |
Previous Message | Michael Paquier | 2016-07-07 07:26:14 | Re: pg_xlogfile_name_offset() et al and recovery |