Re: pg_xlogfile_name_offset() et al and recovery

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp
Cc: michael(dot)paquier(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_xlogfile_name_offset() et al and recovery
Date: 2016-07-07 09:02:08
Message-ID: 20160707.180208.09236665.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

At Thu, 07 Jul 2016 17:26:15 +0900, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <20160707(dot)172615(dot)232806225(dot)horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
> > As the result, this relaxation adds more good than bad and I
> > agree to this.
> >
> > Addition to that, I'd like to propose to add a description (or a
> > notice) about this restriction in documentation that the timeline
> > part of the file name may be wrong. Will post soon.

The following sentense will be added by this patch. Does it make sense?

| Note that these two functions use the timeline ID at the time
| to construct the file name. Therefore they give wrong names for
| transaction log locations on the other timelines. This can
| happen during runtime on replication standby when a promotion
| occurs on itself or upstreams.

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
pg_xlogfile_name_doc_note.diff text/x-patch 847 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2016-07-07 09:26:46 Re: pg_xlogfile_name_offset() et al and recovery
Previous Message Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= 2016-07-07 08:38:40 Re: [PATCH] Set sgml-basic-offset to 1 in .dir-locals.el