Re: Typo Patch

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: CharSyam <charsyam(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Typo Patch
Date: 2016-07-05 19:22:33
Message-ID: 20160705192233.GA504891@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

CharSyam wrote:
> Yes, Some typos problems, It is hard to figure them out.
> But in this patch, guranteed is just misspelling of guaranteed.

I agree with Robert: the sentence as a whole makes no sense:

* We need to check all possible distances, so reset Lpos
* to guaranteed not yet satisfied position.

It's hard to justify changing a single character when what we should be
doing is rewriting the comment completely.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-07-05 19:48:20 Re: can we optimize STACK_DEPTH_SLOP
Previous Message David G. Johnston 2016-07-05 19:18:46 Re: Typo Patch