Re: pg_dump doesn't dump new objects created in schemas from extensions

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Martín Marqués <martin(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: pg_dump doesn't dump new objects created in schemas from extensions
Date: 2016-06-22 13:42:45
Message-ID: 20160622134245.GJ21416@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

* Martín Marqués (martin(at)2ndquadrant(dot)com) wrote:
> El 17/06/16 a las 20:31, Michael Paquier escribió:
> > Integrating some tests with a dummy
> > extension that creates a schema would also be a good idea as this is
> > likely going to modify many code paths. So I think that we should have
> > something stored in src/test/modules that gets installed when running
> > make check in src/bin/pg_dump, and then one of the TAP scripts in t/
> > creates a bunch of objects on the schema created by the extension.
>
> AFAICS there's a test_pg_dump module in src/test/modules which is there
> to test pg_dump with extensions. I think that might be the best place to
> have these tests.

Yes, that's certainly the intent. We can't put the test in
src/bin/pg_dump because the extensions aren't available for installation
when those tests are being run (at least, that was the case when I
tried, which is why src/test/modules/test_pg_dump exists).

Thanks!

Stephen

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2016-06-22 14:32:47 Re: pg_dump doesn't dump new objects created in schemas from extensions
Previous Message Alvaro Herrera 2016-06-22 13:24:03 Re: BUG #14207: A little is lacking to be the most advanced