Re: Error during restore - dump taken with pg_dumpall -c option

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Error during restore - dump taken with pg_dumpall -c option
Date: 2016-05-25 03:33:08
Message-ID: 20160525033308.GW21416@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Rushabh,

* Rushabh Lathia (rushabh(dot)lathia(at)gmail(dot)com) wrote:
> On Fri, May 13, 2016 at 7:27 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>
> > * Rushabh Lathia (rushabh(dot)lathia(at)gmail(dot)com) wrote:
> > > On master branch when we do pg_dumpall with -c option, I can see that
> > > it also dumping the "DROP ROLE pg_signal_backend", which seems wrong.
> > > Because when you restore the dump, its throwing an error
> > > "ERROR: cannot drop role pg_signal_backend because it is required by the
> > > database system".
> >
> > Ah, yes, dropRoles() needs the same change that dumpRoles() got.
> >
> > Will fix, thanks!
>
> Thanks Stephen.

I've puhsed a fix for this.

Thanks!

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2016-05-25 04:01:37 Re: Parallel pg_dump's error reporting doesn't work worth squat
Previous Message Craig Ringer 2016-05-25 02:56:53 Re: To-Do item: skip table scan for adding column with provable check constraints