| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: effective_io_concurrency in 9.6beta |
| Date: | 2016-05-24 18:34:38 |
| Message-ID: | 20160524183438.GA443623@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
> > commit 1aba62ec made zero be an illegal value for effective_io_concurrency.
> > i think this was an accident. If not, then the sample postgresql.conf
> > (at least) needs to be updated.
>
> It looks like the problem is that the new range check
>
> + /* This range check shouldn't fail, but let's be paranoid */
> + return (new_prefetch_pages > 0.0 && new_prefetch_pages < (double) INT_MAX);
>
> should be testing for >= 0.0 not > 0.0.
Hmm, yeah, it looks like that's it. Will fix.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-05-24 19:01:13 | Re: Autovacuum to prevent wraparound tries to consume xid |
| Previous Message | Tom Lane | 2016-05-24 18:28:10 | Re: effective_io_concurrency in 9.6beta |